Feat/stagingBuildTimes #1008
Merged
Feat/stagingBuildTimes #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
approved these changes
Nov 2, 2023
| siteId, | ||
| }, | ||
| }), | ||
| () => new NotFoundError("Site has not been deployed!") |
There was a problem hiding this comment.
nit: this should be a different error since it means the DB couldn't be queried.
There was a problem hiding this comment.
wait no in this case the deployments row doesnt exist, so it is the case that the site has not been deployed!
src/types/stagingBuildStatus.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export const statusStates = { | |||
There was a problem hiding this comment.
nit: this should be fully capitalised with snake case
| isReduceBuildTimesWhitelistedRepo(growthbook) | ||
| ) | ||
| ) | ||
| .andThen((status) => okAsync({ status })) |
There was a problem hiding this comment.
nit: should use .map instead
src/services/infra/InfraService.ts
Outdated
| @@ -37,6 +37,7 @@ import { | |||
| SiteLaunchStatusObject, | |||
| } from "@root/types/siteInfo" | |||
| import { SiteLaunchMessage } from "@root/types/siteLaunch" | |||
| import { isReduceBuildTimesWhitelistedRepo } from "@root/utils/growthbook-utils" | |||
kishore03109
force-pushed
the
feat/stagingBuildTimes
branch
from
ba8ac43 to
666f8a6
Compare
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BE for staging build status. Corresponding FE pr
Closes [insert issue #]
Solution
Get the latest commit as SOT.
Tests
done in fe